Skip to content

Autotools: Update skeleton extension config.m4 template #15147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 29, 2024

  • Comments refactored to a bit more guide way
  • Basic help text added to the HAVE_* CPP macro definitions
  • Raw shell ifs replaced with AS_VAR_IF M4 macros
  • Code wrapped inside the line length of 80 characters
  • pkg-config functionality added on top
  • non-pkg-config functionality added afterwards
  • The loop refactored a bit with a break and check message done afterwards

- Comments refactored to a bit more guide way
- Basic help text added to the HAVE_<EXTENSION>* CPP macro definitions
- Raw shell ifs replaced with AS_VAR_IF M4 macros
- Code wrapped inside the line length of 80 characters
- pkg-config functionality added on top
- non-pkg-config functionality added afterwards
- The loop refactored a bit with a break and check message done
  afterwards
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible

@petk
Copy link
Member Author

petk commented Jul 29, 2024

I've just added two "comment" related adjustments so it's a bit clearer.

@petk petk merged commit 4d46f26 into php:master Jul 29, 2024
1 of 2 checks passed
@petk petk deleted the patch-ext-skeleton-config-template branch July 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants