Virtual props xmlreader

Zend/tests/property_hooks/unserialize.phpt

@@ -54,7 +54,7 @@ object(Test)#2 (1) {
 Test::$prop3::get
 Test::$prop3::set
 
-Warning: unserialize(): Cannot unserialize value for hooked property Test::$prop3 in %s on line %d
+Warning: unserialize(): Cannot unserialize value for virtual property Test::$prop3 in %s on line %d
 
 Warning: unserialize(): Error at offset 26 of 32 bytes in %s on line %d
 bool(false)

build/gen_stub.php

@@ -2916,6 +2916,7 @@ class PropertyInfo extends VariableLike
     public ?Expr $defaultValue;
     public ?string $defaultValueString;
     public bool $isDocReadonly;
+    public bool $isVirtual;
 
     /**
      * @var AttributeInfo[] $attributes
@@ -2929,6 +2930,7 @@ public function __construct(
         ?Expr $defaultValue,
         ?string $defaultValueString,
         bool $isDocReadonly,
+        bool $isVirtual,
         ?string $link,
         ?int $phpVersionIdMinimumCompatibility,
         array $attributes,
@@ -2939,6 +2941,7 @@ public function __construct(
         $this->defaultValue = $defaultValue;
         $this->defaultValueString = $defaultValueString;
         $this->isDocReadonly = $isDocReadonly;
+        $this->isVirtual = $isVirtual;
         parent::__construct($flags, $type, $phpDocType, $link, $phpVersionIdMinimumCompatibility, $attributes, $exposedDocComment);
     }
 
@@ -3054,6 +3057,10 @@ protected function getFlagsByPhpVersion(): array
             $flags = $this->addFlagForVersionsAbove($flags, "ZEND_ACC_READONLY", PHP_82_VERSION_ID);
         }
 
+        if ($this->isVirtual) {
+            $flags = $this->addFlagForVersionsAbove($flags, "ZEND_ACC_VIRTUAL", PHP_84_VERSION_ID);
+        }
+
         return $flags;
     }
 
@@ -4433,6 +4440,7 @@ function parseProperty(
 ): PropertyInfo {
     $phpDocType = null;
     $isDocReadonly = false;
+    $isVirtual = false;
     $link = null;
 
     if ($comments) {
@@ -4444,6 +4452,8 @@ function parseProperty(
                 $isDocReadonly = true;
             } elseif ($tag->name === 'link') {
                 $link = $tag->value;
+            } elseif ($tag->name === 'virtual') {
+                $isVirtual = true;
             }
         }
     }
@@ -4472,6 +4482,7 @@ function parseProperty(
         $property->default,
         $property->default ? $prettyPrinter->prettyPrintExpr($property->default) : null,
         $isDocReadonly,
+        $isVirtual,
         $link,
         $phpVersionIdMinimumCompatibility,
         $attributes,

ext/reflection/php_reflection.c

@@ -6041,7 +6041,7 @@ ZEND_METHOD(ReflectionProperty, getSettableType)
 	}
 
 	/* Get-only virtual property can never be written to. */
-	if ((prop->flags & ZEND_ACC_VIRTUAL) && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {
+	if (prop->hooks && (prop->flags & ZEND_ACC_VIRTUAL) && !prop->hooks[ZEND_PROPERTY_HOOK_SET]) {
 		zend_type never_type = ZEND_TYPE_INIT_CODE(IS_NEVER, 0, 0);
 		reflection_type_factory(never_type, return_value, 0);
 		return;

ext/standard/var_unserializer.re

@@ -561,7 +561,7 @@ static int is_property_visibility_changed(zend_class_entry *ce, zval *key)
 				return 1;
 			} else {
 				php_error_docref(NULL, E_WARNING,
-					"Cannot unserialize value for hooked property %s::$%s",
+					"Cannot unserialize value for virtual property %s::$%s",
 					ZSTR_VAL(existing_propinfo->ce->name), Z_STRVAL_P(key));
 				zval_ptr_dtor_str(key);
 				return -1;

ext/xmlreader/php_xmlreader.stub.php

@@ -99,32 +99,46 @@ class XMLReader
     public const int SUBST_ENTITIES = UNKNOWN;
 
 
+    /** @virtual */
     public int $attributeCount;
 
+    /** @virtual */
     public string $baseURI;
 
+    /** @virtual */
     public int $depth;
 
+    /** @virtual */
     public bool $hasAttributes;
 
+    /** @virtual */
     public bool $hasValue;
 
+    /** @virtual */
     public bool $isDefault;
 
+    /** @virtual */
     public bool $isEmptyElement;
 
+    /** @virtual */
     public string $localName;
 
+    /** @virtual */
     public string $name;
 
+    /** @virtual */
     public string $namespaceURI;
 
+    /** @virtual */
     public int $nodeType;
 
+    /** @virtual */
     public string $prefix;
 
+    /** @virtual */
     public string $value;
 
+    /** @virtual */
     public string $xmlLang;
 
     /** @tentative-return-type */

ext/xmlreader/tests/virtual_properties.phpt

@@ -0,0 +1,34 @@
+--TEST--
+Virtual property tests
+--EXTENSIONS--
+xmlreader
+--FILE--
+<?php
+
+$rc = new ReflectionClass(XMLReader::class);
+$prop = $rc->getProperty("nodeType");
+var_dump($prop->isVirtual());
+var_dump($prop->getSettableType());
+var_dump($prop->getHooks());
+var_dump($prop->getRawValue(new XMLReader));
+var_dump($prop->getValue(new XMLReader));
+
+$reader = XMLReader::XML("<root>hi</root>");
+var_dump(json_encode($reader));
+var_export($reader); echo "\n";
+var_dump(get_object_vars($reader));
+
+?>
+--EXPECTF--
+bool(true)
+object(ReflectionNamedType)#%d (0) {
+}
+array(0) {
+}
+int(0)
+int(0)
+string(2) "{}"
+\XMLReader::__set_state(array(
+))
+array(0) {
+}