Fix throw in IS_IDENTICAL in JIT #15103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to persist opline in case zend_is_identical() throws.
dstogov
reviewed
Jul 25, 2024
| case ZEND_IS_NOT_IDENTICAL: | ||
| case ZEND_CASE_STRICT: | ||
| /* Array to array comparison may lead to recursion. */ | ||
| return (t1 & t2) & MAY_BE_ARRAY_OF_ARRAY; |
There was a problem hiding this comment.
I think you should also add MAY_BE_ARRAY_OF_OBJECT to supprt indirectly recursive structures.
There was a problem hiding this comment.
@dstogov With ===, objects are compared by-reference (or object identity), so I believe they are not of concern here.
fyi, these github action urls to logfiles will be pruned after a few months. in case there is something important for this PR to know from this github action log, you should put it into the PR description |
dstogov
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to persist opline in case zend_is_identical() throws.
For context: https://github.com/php/php-src/actions/runs/10086589614/job/27889461092