Skip to content

spi/phpdbg: windows update exception type falling into segfault. #15098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen
Copy link
Member Author

devnexen commented Jul 24, 2024

I did not add the undocumented 0xE06D7363. Potentially for C++ extensions catching exceptions I guess, but does not fall into the segfault category.

@devnexen devnexen force-pushed the phpwindbg_except_upd branch from a515185 to 2aeed0a Compare July 24, 2024 20:20
@devnexen devnexen marked this pull request as ready for review July 24, 2024 20:34
@Girgias Girgias requested a review from bwoebi July 25, 2024 22:22
@cmb69
Copy link
Member

cmb69 commented Aug 1, 2024

Makes sense to me, but maybe adjust the error message at the call side:

php-src/sapi/phpdbg/phpdbg.c

Lines 1629 to 1631 in 1ca3230

} __except(phpdbg_exception_handler_win32(xp = GetExceptionInformation())) {
phpdbg_error("Access violation (Segmentation fault) encountered\ntrying to abort cleanly...");
}

Maybe just say "Segmentation fault encountered\ntrying to abort cleanly...", since this is no longer about actual AVs.

@devnexen devnexen force-pushed the phpwindbg_except_upd branch from 2aeed0a to 81abca2 Compare August 1, 2024 10:19
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@devnexen devnexen closed this in 3c36c73 Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants