Autotools: Sync CS in opcache Capstone check #15084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Jul 23, 2024
petk
commented
- Added Capstone check message in configure log
- PKG_CHECK_MODULES already errors out by default if Capstone is not found with a bit more informative message
- Autoconf syntax used
- HAVE_CAPSTONE help text synced and updated
- Added Capstone check message in configure log - PKG_CHECK_MODULES already errors out by default if Capstone is not found with a bit more informative message - Autoconf syntax used - HAVE_CAPSTONE help text synced and updated
dstogov
reviewed
Jul 24, 2024
Comment on lines
-90
to
-93
| ],[ | ||
| AC_MSG_ERROR([capstone >= 3.0 required but not found]) | ||
| ]) | ||
| ]) |
There was a problem hiding this comment.
What is the reason to remove this?
There was a problem hiding this comment.
Default PKG_CHECK_MODULES error message is thrown if the 4th argument is empty:
checking whether to enable JIT... yes
checking whether to support opcache JIT dissasembly through Capstone... yes
checking for capstone >= 3.0.0... no
configure: error: Package requirements (capstone >= 3.0.0) were not met:
Package 'capstone' not found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables CAPSTONE_CFLAGS
and CAPSTONE_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
otherwise if the 4th argument is added, the error message is like this:
checking whether to enable JIT... yes
checking for capstone >= 3.0.0... no
configure: error: capstone >= 3.0 required but not found
dstogov
approved these changes
Jul 24, 2024
deAtog
pushed a commit
to deAtog/php-src
that referenced
this pull request
Jul 26, 2024
- Added Capstone check message in configure log - PKG_CHECK_MODULES already errors out by default if Capstone is not found with a bit more informative message - Autoconf syntax used - HAVE_CAPSTONE help text synced and updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.