Skip to content

Fix bogus fallthrough path in firebird_handle_get_attribute() #15066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix bogus fallthrough path in firebird_handle_get_attribute() #15066

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

If getting the version fails, we should return -1 according to php_pdo_driver.h:259, not fall through to another attribute.

@nielsdos
Fix bogus fallthrough path in firebird_handle_get_attribute()
61ba7e1 
If getting the version fails, we should return -1 according to
php_pdo_driver.h:259, not fall through to another attribute.
SakiTakamachi
SakiTakamachi approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice at all, thank you for finding this!

@nielsdos nielsdos closed this in b8e9c5b Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakiTakamachi SakiTakamachi SakiTakamachi approved these changes

Assignees
No one assigned
Labels
Extension: pdo_firebird
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @SakiTakamachi