Skip to content

Autotools: Fix unused result and variables warnings in flush IO check #15056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 21, 2024

  • exit() replaced with regular return since these two behave the same in main()
  • main(void) used as argc and argv aren't used
  • if sentences wrapped in curly brackets for readability
  • fgets wrapped in if to check for the return result and omit the "ignoring return value of 'fgets' declared with attribute 'warn_unused_result'..." warnings in the config.log

- exit() replaced with regular return since these two behave the same in
  main()
- main(void) used as argc and argv aren't used
- if sentences wrapped in curly brackets for readability
- fgets wrapped in if to check for the return result and omit the
  "ignoring return value of 'fgets' declared with attribute
  'warn_unused_result'..." warnings in the config.log
@petk petk merged commit fe9fdd4 into php:master Jul 22, 2024
11 checks passed
@petk petk deleted the patch-flush-io-1 branch July 22, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants