Throw instead of silently failing when creating a too long text node #15014
Conversation
|
Looks like the test fails on CI because of a different libxml version. Damn how I wish we could just bump it to at least 2.10.x or so... |
How long has 2.10 been available? |
August of 2022, but most distros are still on 2.9.x. Which means they suffer from tons of bugs because distros just pick a version, stick with it for a long time and only backport security fixes. |
pain CentOS is going to be the most annoying one again. |
Fortunately, it's gone https://endoflife.date/centos |
Lower branches suffer from this as well but we cannot change the behaviour there. We also add NULL checks to check for allocation failure.
nielsdos
force-pushed
the
parentnode-child-node-too-long-text
branch
from
9e686b5 to
0ff6c54
Compare
|
I slightly adapted the PR so it works with all libxml versions. New libxml versions fail when the string length is too long or the allocation fails. Old libxml versions only fail when allocation fails and silently truncate the string when the string is too long. |
Lower branches suffer from this as well but we cannot change the behaviour there.