Revert "[skip ci] Skip bug45161.phpt on Windows" #14998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b22c3e.
|
@iluuu1994, since you've added the SKIPIF section in response to #10753, what do you think about reverting it now?Apparently the test runs in less than a second on PHP 8.2 with cURL 8.6.2. (Note that the PR must not be merged as is; the 2nd commit was to show the execution time only.) |
|
@cmb69 Sounds good! If it causes issues again we can always revert the revert. 😄 |
|
Fine, I'll push the revert. |
|
And it looks good so far. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b22c3e.
Just testing.