Skip to content

Update the php-sdk-binary-tools to php-sdk-2.3.0 #14991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 17, 2024

The Windows CI of the PHP-8.1 to PHP-8.3 branches still use the php-sdk-2.2.0 which is almost five years old, and does not fetch the updated dependencies from https://downloads.php.net/~windows.

The master branch CI uses php_downloads_server_migration_v1, which has been superseded a few months ago[1]. So switching to the php-sdk-2.3.0 makes sense there, too.

[1] php/php-sdk-binary-tools@19c8ccb

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me :)

edit:
Maybe your base branch is too old?

@cmb69
Copy link
Member Author

cmb69 commented Jul 17, 2024

To clarify: the only relevant change here is that the dependency libraries are now fetched from https://downloads.php.net/~windows/php-sdk/deps/ instead of https://windows.php.net/downloads/php-sdk/deps/, since the latter are no longer up-to-date, and there have been a few updates even to the 8.1 dependencies in the meantime. Obviously, building against the out-dated dependencies should still work, but if new Windows builds are done, something might not quite work as expected, and to avoid (or at least minimize) that, doing the CI builds with the latest dependencies seems to be prudent.

@bukka, you've made #12085 against master only; what do you think about basically back-porting this?

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to update it in lower branches but not sure about 8.1 as we don't usually do those sort of fixes for security support only branches but I would be fine with that if I was RM of that version.

I guess we can push it there and if @ramsey is not happy, we can revert it but it's just pipeline change so should be fine.

@cmb69
Copy link
Member Author

cmb69 commented Jul 17, 2024

Yeah, targeting 8.1 might not be the best idea. I'm closing this for now, and will re-target/re-open later (I'm currently busy otherwise).

@cmb69 cmb69 closed this Jul 17, 2024
@cmb69 cmb69 reopened this Jul 17, 2024
@cmb69 cmb69 changed the base branch from PHP-8.1 to PHP-8.2 July 17, 2024 19:25
@cmb69 cmb69 requested review from iluuu1994 and TimWolla as code owners July 17, 2024 19:25
The Windows CI of the `PHP-8.1` to `PHP-8.3` branches still use the
`php-sdk-2.2.0` which is almost five years old, and does not fetch the
updated dependencies from https://downloads.php.net/~windows.

The `master` branch CI uses `php_downloads_server_migration_v1`, which
has been superseded a few months ago[1].  So switching to the
`php-sdk-2.3.0` makes sense there, too.

[1] <php/php-sdk-binary-tools@19c8ccb>
@cmb69 cmb69 force-pushed the cmb/update-php-sdk-2 branch from 130a2cd to dab569e Compare July 17, 2024 20:58
@cmb69 cmb69 closed this in 93a9a9b Jul 19, 2024
@cmb69 cmb69 deleted the cmb/update-php-sdk-2 branch July 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants