round(): Corrected test name and fixed UPGRADING
#14943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a concrete example regarding the change in which the number of digits rounded by round() was extended by one digit.
SakiTakamachi
force-pushed
the
fix/round_expand
branch
from
da8f665 to
d8c8fa3
Compare
cmb69
reviewed
Jul 29, 2024
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the following thread for the motivation for fixing UPGRADING:
https://externals.io/message/124407
The test name had a mixture of
-and_, so I changed it to_.The explanation for UPGRADING was too simple, so I added a concrete example to make the motivation for the change easier to understand.
(Extraneous space is being removed, but this is due to IDE behavior....)