ext/pdo_firebird: Added Pdo\Firebird::ATTR_API_VERSION

[SakiTakamachi]

This return FB_API_VER.

Related #14897

The functions that are built change depending on the value of FB_API_VER described in ibase.h, but the only way for users to know this value is to actually look at ibase.h, so add an attribute value to make it possible to obtain it.

[sim1984]

Maybe it's worth adding this information to phpinfo as well?

PHP_MINFO_FUNCTION(pdo_firebird) /* {{{ */
{
	char version[64];
	isc_get_client_version(version);

	php_info_print_table_start();
	php_info_print_table_row(2, "PDO Driver for Firebird", "enabled");
	php_info_print_table_row(2, "Client Library Version", version);
        php_info_print_table_row(2, "Firebird API version", FB_API_VER);
	php_info_print_table_end();
}
/* }}} */

[Girgias]

Yes, this should also be added to phpinfo

[SakiTakamachi]

Okay, I'll add it later

[SakiTakamachi]

done

[Girgias]

Actually, is this related to the server, or the driver?

As it might make more sense to expose it via PDO::ATTR_SERVER_INFO

[SakiTakamachi]

This only related to the header file ibase.h at build time.

The server side is completely irrelevant.

The client side is somewhat involved, but due to factors such as updates, the header file version at the time of build and the client version do not always match.

[Girgias]

Right, then this is fine.

[cmb69]

Overall, this looks sensible to me, but I wonder about the PDO driver specific subclasses; shouldn't PDO::FB_ATTR_API_VERSION be rather something like PdoFirebird::ATTR_API_VERSION?

[SakiTakamachi]

@cmb69
Indeed, makes sense.

Firstly I forgot to add this to the stub.

And other constants that are new in 8.4 (such as transaction isolation levels) should probably be been the same way. However, other constants will be addressed in a follow-up PR.

I'll fix this, thx!

[SakiTakamachi]

FYI:

PdoFirebird class has become Pdo\Firebird. The same for other drivers :)

[SakiTakamachi]

done!

[SakiTakamachi]

I realized while changing this that the stub's extends PDO should probably be extends \PDO.
I'll fix it in a follow-up PR. PRs will be opened one by one, as the Stub hash will conflict and cause trouble.

[cmb69]

Thank you! Looks good to me.