Skip to content

CI: Updated firebird version to 4.x in windows ci #14912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Jul 11, 2024

3.x to 4.x

@cmb69
Copy link
Member

cmb69 commented Jul 11, 2024

I think this may make sense, although PDO_Firebird will still be build for v3, because the client lib is fbclient-3.0.6 (see https://downloads.php.net/~windows/php-sdk/deps/series/packages-8.4-vs17-x86-staging.txt, etc.)

To update the client lib, it should be sufficient to get the kits from https://www.firebirdsql.org/en/firebird-4-0/, and to repackage the lib and the required headers, and upload them to the deps/ directory.

/cc @shivammathur

@TimWolla TimWolla removed their request for review July 11, 2024 11:57
@shivammathur
Copy link
Member

shivammathur commented Jul 11, 2024

@SakiTakamachi @cmb69

I have added fbclient-4.0.4 and updated the series files for PHP 8.4 and the master branch.

@cmb69 cmb69 merged commit c4f1c5c into php:master Jul 16, 2024
11 checks passed
@cmb69
Copy link
Member

cmb69 commented Jul 16, 2024

I've just merged the PR. Thank you!

@SakiTakamachi SakiTakamachi deleted the ci/update_firebird_version branch July 16, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants