Skip to content

Zend: Add ZEND_BYTES_SWAP32/ZEND_BYTES_SWAP64 #14910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Jul 11, 2024

There is code for bytes swap in ext/hash, etc., but I haven't changed it because it's in the library used.

@Girgias Girgias removed their request for review July 11, 2024 11:42
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this seems fine, but let's wait for Dmitry's review since this is touching his code.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@SakiTakamachi SakiTakamachi merged commit 8a4a304 into php:master Jul 22, 2024
11 checks passed
@SakiTakamachi SakiTakamachi deleted the add_zend_bytes_swap branch July 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants