Autotools: Refactor ptrace check for PHP-FPM #14907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Jul 10, 2024
petk
commented
- This syncs CS and wraps ptrace function check in a single AC_CACHE_CHECK for optional edge case cross-compiling adjustments
- Overquoted arguments are reduced (first the compilation check if ptrace in proper form is available on the system and then the run check if ptrace works as expected)
- The cache variable php_cv_have_mach_vm_read is renamed to php_cv_func_mach_vm_read.
- This syncs CS and wraps ptrace function check in a single AC_CACHE_CHECK for optional edge case cross-compiling adjustments - Overquoted arguments are reduced (first the compilation check if ptrace in proper form is available on the system and then the run check if ptrace works as expected) - The cache variable php_cv_have_mach_vm_read is renamed to php_cv_func_mach_vm_read.
devnexen
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.