Skip to content

ext/gd/tests/gh10614.phpt: skip if no PNG support #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

orlitzky
Copy link
Contributor

This test uses imagecreatefrompng(), which won't be there if libgd was built without PNG support.

This test uses imagecreatefrompng(), which won't be there if libgd was
built without PNG support.
@petk
Copy link
Member

petk commented Jul 10, 2024

Wouldn't it be simpler to just check if imagecreatefrompng() exists?

@orlitzky
Copy link
Contributor Author

Wouldn't it be simpler to just check if imagecreatefrompng() exists?

Probably, and I think this came up in the initial PR too, but I've just copied what's already there in the other checks for PNG support.

@petk
Copy link
Member

petk commented Jul 10, 2024

Probably, and I think this came up in the initial PR too, but I've just copied what's already there in the other checks for PNG support.

Ah, ok. Yes, I see. This check is like if the entire PNG functionality is available. Ok, that makes sense since there are at least two png related functions in GD.

@petk
Copy link
Member

petk commented Jul 10, 2024

Then I'd also suggest that this goes to PHP-8.2 (when merging).

@nielsdos
Copy link
Member

Then I'd also suggest that this goes to PHP-8.2 (when merging).

This should indeed go into 8.2. I'll pick it up. Thanks.

@nielsdos nielsdos closed this in 09957ab Jul 10, 2024
@orlitzky
Copy link
Contributor Author

Cool, thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants