Skip to content

ext/gd minor corrections concerning image format id for errors. #14887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jul 9, 2024

No description provided.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but the PR title seems unrelated to the code changes?

@devnexen
Copy link
Member Author

devnexen commented Jul 9, 2024

The tn arguments refers to the image type for the warnings like

		php_error_docref(NULL, E_WARNING, "Passed data is not in \"%s\" format", tn);

So not formely image type id but just for this purpose if that makes sense.

@Girgias
Copy link
Member

Girgias commented Jul 9, 2024

The tn arguments refers to the image type for the warnings like

		php_error_docref(NULL, E_WARNING, "Passed data is not in \"%s\" format", tn);

So not formely image type id but just for this purpose if that makes sense.

Ah right

@devnexen devnexen merged commit 93c3ebd into php:master Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants