Skip to content

Simplify a duplicate declaration #14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2024
Merged

Simplify a duplicate declaration #14880

merged 1 commit into from
Jul 9, 2024

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Jul 8, 2024

The two parts of the #if condition are the same.

@jvoisin
Simplify a duplicate declaration
3a8ba69 
The two parts of the #if condition are the same.
@jvoisin jvoisin requested a review from dstogov as a code owner July 8, 2024 21:23
petk
petk approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@petk petk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. Thank you.

devnexen
devnexen approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@devnexen devnexen merged commit c2cbbd9 into php:master Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petk petk petk approved these changes

@devnexen devnexen devnexen approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvoisin @petk @devnexen