ext/bcmath: Added scale to bc_compare argument #14802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original specification, the scale of bc_num was directly changed and compared. This becomes a problem when objects are supported, so we will modify it to compare without changing bc_num.
Girgias
reviewed
Jul 11, 2024
| @@ -39,7 +39,7 @@ | |||
| than N2 and +1 if N1 is greater than N2. If USE_SIGN is false, just | |||
| compare the magnitudes. */ | |||
|
|
|||
| bcmath_compare_result _bc_do_compare(bc_num n1, bc_num n2, bool use_sign) | |||
| bcmath_compare_result _bc_do_compare(bc_num n1, bc_num n2, size_t scale, bool use_sign) | |||
There was a problem hiding this comment.
The new scale parameter is unused?
There was a problem hiding this comment.
No, it used on L76 and 77.
|
I'm not sure I understand (yet) why this is needed. |
|
If specify a scale to compare values on a smaller scale than they should be, must change I don't want to do this with |
nielsdos
approved these changes
Jul 11, 2024
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original specification, the scale of bc_num was directly changed and compared.
This becomes a problem when objects are supported, so we will modify it to compare without changing bc_num.