ext/standard/tests: use %d instead of bytes in an overflow message #14788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In strings/chunk_split_variation1_32bit.phpt, we have a test that is expected to fail on x32 with a possible integer overflow error. The message reports the exact number of bytes -- a number big enough to overflow an int on x32 -- stemming from a memory allocation in chunk_split(). This number appears unpredictable, and is not the point of the test. We replace it with %d to make the test independent of the allocation details.
|
Thanks for finding this. This is probably best to go to PHP-8.2 so it's fixed also there (when merging)... |
Girgias
approved these changes
Jul 3, 2024
|
Merged via a8d1955 to PHP-8.2 and up. |
|
Thanks! The other half of our bug report looks related but I got sidetracked. I'll deal with it in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
strings/chunk_split_variation1_32bit.phpt, we have a test that is expected to fail on x32 with a possible integer overflow error. The message reports the exact number of bytes -- a number big enough to overflow an int on x32 -- stemming from a memory allocation inchunk_split().This number appears unpredictable, and is not the point of the test. We replace it with
%dto make the test independent of the allocation details.(This fixes half of https://bugs.gentoo.org/935382)