Skip to content

Fix stack limit on ASAN/MSAN #14771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Jul 2, 2024

  • Increase the reserved stack size in ASAN builds, as instrumentation use more stack
  • Increase the max allowed stack size in some tests, and enable these tests under ASAN
  • Use __builtin_frame_address(0), instead of some stack variable, when we need a stack address, as ASAN may store local variables outside of the real stack

@arnaud-lb arnaud-lb force-pushed the reserved-stack-asan branch from a9be4d1 to 153b09f Compare July 2, 2024 19:14
@iluuu1994
Copy link
Member

I tested this both with GCC+ASAN and Clang+MSAN, and it works! 🥳 Thank you @arnaud-lb!

@arnaud-lb arnaud-lb changed the title Reserved stack asan Fix stack limit on ASAN/MSAN Jul 3, 2024
@arnaud-lb arnaud-lb marked this pull request as ready for review July 3, 2024 12:01
@arnaud-lb
Copy link
Member Author

Thank you for testing @iluuu1994!

@arnaud-lb arnaud-lb merged commit 0bd2602 into php:master Jul 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants