Skip to content

sapi/cli: setting process name little optimisation. #14767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

sapi/cli: setting process name little optimisation. #14767

merged 1 commit into from
Jul 2, 2024

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jul 2, 2024

No description provided.

@devnexen devnexen force-pushed the sapi_cli_ps_title_optim branch 2 times, most recently from 1e5f8f8 to 7805cdf Compare July 2, 2024 08:02
@devnexen devnexen marked this pull request as ready for review July 2, 2024 08:34
nielsdos
nielsdos requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right. Strlcpy is misdesigned in that it returns the number of bytes that would be needed, not the number of bytes that are written.

@devnexen
Copy link
Member Author

devnexen commented Jul 2, 2024

ah true that..

@devnexen devnexen force-pushed the sapi_cli_ps_title_optim branch from 7805cdf to 99c5723 Compare July 2, 2024 10:29
nielsdos
nielsdos approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could in theory use the MIN macro (for the variable), but this is fine too.

@devnexen devnexen merged commit 6b03720 into php:master Jul 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos