Skip to content

[part of RFC] Implement PHP-specific extensions to Dom #14754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

[part of RFC] Implement PHP-specific extensions to Dom #14754

merged 1 commit into from
Jul 4, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 1, 2024

@nielsdos nielsdos mentioned this pull request Jul 1, 2024
Closed
@nielsdos nielsdos changed the title Implement PHP-specific extensions to Dom [part of RFC] Implement PHP-specific extensions to Dom Jul 1, 2024
@nielsdos nielsdos added the RFC label Jul 1, 2024
@nielsdos nielsdos force-pushed the extra-dom-additions-1 branch from c7b4b64 to c269541 Compare July 3, 2024 17:34
@nielsdos nielsdos marked this pull request as ready for review July 3, 2024 17:36
@nielsdos nielsdos requested a review from kocsismate as a code owner July 3, 2024 17:36
@nielsdos nielsdos requested a review from Girgias July 3, 2024 17:36
Girgias
Girgias approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@nielsdos nielsdos merged commit cf914f4 into php:master Jul 4, 2024
10 of 11 checks passed
@jtojnar jtojnar mentioned this pull request Aug 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: dom RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias