Skip to content

Autotools: Sync PHP_SUBST in ext/gd #14751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Autotools: Sync PHP_SUBST in ext/gd #14751

merged 1 commit into from
Jul 1, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 1, 2024

  • Argument quoted
  • CFLAGS variable changed into normal shell variable
  • GDLIB_CFLAGS and GDLIB_LIBS are not used in the generated Makefile

@petk
Autotools: Sync PHP_SUBST in ext/gd
9fd4813 
- Argument quoted
- CFLAGS variable changed into normal shell variable
- GDLIB_CFLAGS and GDLIB_LIBS are not used in the generated Makefile
@petk petk requested a review from devnexen as a code owner July 1, 2024 15:21
devnexen
devnexen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@petk petk merged commit 0346217 into php:master Jul 1, 2024
10 of 11 checks passed
@petk petk deleted the patch-PHP_SUBST-ext-gd branch July 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: gd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen