Skip to content

Sync PHP_SUBST_OLD #14746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

Sync PHP_SUBST_OLD #14746

merged 1 commit into from
Jul 1, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 1, 2024

  • All arguments quoted
  • PHP_VERSION, PHP_VERSION_ID, PHP_LDFLAGS are used only in templates with @...@ placeholders
  • These are not used in generated Makefile neither in templates: abs_builddir, abs_srcdir, DEBUG_CFLAGS
  • These are used only in generated Makefile: EXTRA_LDFLAGS, EXTRA_LDFLAGS_PROGRAM, ZEND_EXTRA_LIBS, INCLUDES, EXTRA_INCLUDES, INSTALL_IT, NATIVE_RPATHS

@petk
Sync PHP_SUBST_OLD
21da040 
- All arguments quoted
- PHP_VERSION, PHP_VERSION_ID, PHP_LDFLAGS are used only in templates
  with @...@ placeholders
- These are not used in generated Makefile neither in templates:
  abs_builddir, abs_srcdir, DEBUG_CFLAGS
- These are used only in generated Makefile: EXTRA_LDFLAGS,
  EXTRA_LDFLAGS_PROGRAM, ZEND_EXTRA_LIBS, INCLUDES, EXTRA_INCLUDES,
  INSTALL_IT, NATIVE_RPATHS
@petk petk merged commit 7232636 into php:master Jul 1, 2024
11 checks passed
@petk petk deleted the patch-PHP_SUBST_OLD branch July 1, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen