Skip to content

Remove unused defined CPP macros in fpm SAPI #14740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2024
Merged

Remove unused defined CPP macros in fpm SAPI #14740

merged 2 commits into from
Jul 1, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 30, 2024

  • PHP_FPM_SYSTEMD
  • PHP_FPM_USER
  • PHP_FPM_GROUP

@petk
Remove unused defined CPP macros in fpm SAPI
8e6041c 
- PHP_FPM_SYSTEMD
- PHP_FPM_USER
- PHP_FPM_GROUP
@petk petk requested a review from bukka as a code owner June 30, 2024 22:05
devnexen
devnexen approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems safe to remove

@petk petk merged commit bf139e9 into php:master Jul 1, 2024
2 checks passed
@petk petk deleted the patch-remove-unused-fpm-defines branch July 1, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Build System SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen