Fix GH-14687 segfault on debugging a freed SplObjectIterator instance. #14711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another route which can be taken is to not display the glob node if this makes no sense in this case. |
nielsdos
requested changes
Oct 28, 2024
| $s[$phar] = new HasDestructor(); | ||
| register_shutdown_function(function() { | ||
| global $s; | ||
| }); |
There was a problem hiding this comment.
Please close the test with ?>, this is necessary so we can run the test directly.
ext/spl/tests/gh14687.phpt
Outdated
| phar.readonly=0 | ||
| --FILE-- | ||
| <?php | ||
| $fname = __DIR__ . '/' . basename(__FILE__, '.php') . '.phar.zip'; |
There was a problem hiding this comment.
You're creating a file here, but have no clean section. Please add a clean section.
There was a problem hiding this comment.
Also it's better to just hardcode the filename to __DIR__ . '/gh14687.phar.zip' because otherwise you can't use the same name in the clean section because the base name for the clean file contains the "clean" word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.