Skip to content

hash: Add simple HashContext::__debugInfo() implementation #14644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

TimWolla
Copy link
Member

Alternatively a public readonly string $algo; could be added to the object. It would implicitly show up in the debug info output and can also be programmatically be accessed. But I'm not sure of programmatic access to just the $algo is useful, without also having the flags and/or HMAC key.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, should have an UPGRADING entry somewhere.

@TimWolla TimWolla changed the title hash: Add simply HashContext::__debugInfo() implementation hash: Add simple HashContext::__debugInfo() implementation Jun 27, 2024
@TimWolla TimWolla merged commit ac54d1c into php:master Jun 27, 2024
8 of 11 checks passed
@TimWolla TimWolla deleted the hash-context-debugInfo branch June 27, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants