Skip to content

Enable static tsrmls cache in pdo_mysql with mysqlnd #14634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

petk
Copy link
Member

@petk petk commented Jun 22, 2024

The tsrmls cache has been integrated in
aac7b1d but not enabled when pdo_mysql is built for mysqlnd extension.

Unless I'm missing something and this is intentionally disabled for pdo_mysql and mysqlnd build on Windows.

The tsrmls cache has been integrated in
aac7b1d but not enabled when pdo_mysql
is built for mysqlnd extension.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks an oversight

@petk
Copy link
Member Author

petk commented Jun 23, 2024

This looks an oversight

I think so too, yes. Thanks for the reviews because these syncs help enormously to improve the build system in the future...

@petk petk merged commit 8d876e4 into php:master Jun 23, 2024
9 of 11 checks passed
@petk petk deleted the patch-pdo-mysql-ZEND_ENABLE_STATIC_TSRMLS_CACHE branch June 23, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants