Skip to content

Bump minimum libpq version to 10.0 #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Jun 21, 2024

This bumps the libpq client-side PostgreSQL library minimum required version from 9.1 to 10.0.

  • Sanity check: PQlibVersion -> PQencryptPasswordConn (available since libpq 10.0)
  • PQsetErrorContextVisibility (available since libpq 9.6)
  • lo_truncate64 (available since libpq 9.3), if 32-bit system doesn't support lo_*64 functions, error is returned and functions are always available

Additionally, the conditional functions usages in pdo_pgsql and pgsql extensions that got piled up are cleaned and synced:

  • pg_prepare (PQprepare available since libpq 7.4)
  • pg_query_params (PQexecParams available since libpq 7.4)
  • pg_result_error_field (PQresultErrorField available since libpq 7.4)
  • pg_send_prepare (PQsendPrepare available since libpq 7.4)
  • pg_send_query_params (PQsendQueryParams available since libpq 7.4)
  • pg_set_error_verbosity (PQsetErrorVerbosity available since libpq 7.4)
  • pg_transaction_status (PQtransactionStatus available since libpq 7.4)

The Windows libpq version updated to current 11.4 available at https://github.com/winlibs/postgresql

Discussion: https://news-web.php.net/php.internals/123609
Follow-up of GH-14540

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk petk force-pushed the patch-pgsql-version-bump branch from 24cc121 to 3f8c979 Compare June 23, 2024 23:06
This bumps the libpq client-side PostgreSQL library minimum required
version from 9.1 to 10.0.

- Sanity check: PQlibVersion -> PQencryptPasswordConn (available since
  libpq 10.0)
- PQsetErrorContextVisibility (available since libpq 9.6)
- lo_truncate64 (available since libpq 9.3), if 32-bit system doesn't
  support lo_*64 functions, error is returned and functions are always
  available

Additionally, the conditional functions usages in pdo_pgsql and pgsql
extensions that got piled up are cleaned and synced:

- pg_prepare (PQprepare available since libpq 7.4)
- pg_query_params (PQexecParams available since libpq 7.4)
- pg_result_error_field (PQresultErrorField available since libpq 7.4)
- pg_send_prepare (PQsendPrepare available since libpq 7.4)
- pg_send_query_params (PQsendQueryParams available since libpq 7.4)
- pg_set_error_verbosity (PQsetErrorVerbosity available since libpq 7.4)
- pg_transaction_status (PQtransactionStatus available since libpq 7.4)

The Windows libpq version is currently at version 11.4:
https://github.com/winlibs/postgresql

Discussion: https://news-web.php.net/php.internals/123609
Follow-up of phpGH-14540
@petk petk force-pushed the patch-pgsql-version-bump branch from 3f8c979 to 297817a Compare June 23, 2024 23:07
@petk
Copy link
Member Author

petk commented Jun 23, 2024

Branch only rebased against the current master due to that win32/build/libs_version.txt file removed in the recent commit and commit message synced.

@petk petk merged commit 4f450b6 into php:master Jun 25, 2024
9 of 11 checks passed
@petk petk deleted the patch-pgsql-version-bump branch June 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants