Code

Implement pcntl_waitid#14617

Code

Closed

vrza wants to merge 44 commits intophp:masterphp/php-src:masterfrom

vrza:waitidvrza/php-src:waitidCopy head branch name to clipboard

Commits

Commits on Jun 20, 2024

• ext/pcntl: Added new function pcntl_waitid

  vrza

  committed
  1fe4de1

  Copy full SHA for 1fe4de1

• Validate flags, fill siginfo array

  vrza

  committed
  0483f22

  Copy full SHA for 0483f22

• Expose needed constants from wait.h

  vrza

  committed
  ecefc18

  Copy full SHA for ecefc18

• Add ifdef guards around WEXITED, WSTOPPED, WNOWAIT

  vrza

  committed
  c8ff3b6

  Copy full SHA for c8ff3b6

• Unit tests for pcntl_waitid

  vrza

  committed
  2dd62b9

  Copy full SHA for 2dd62b9

• Throw a ValueError if parameter validation fails

  vrza

  committed
  0ccd92f

  Copy full SHA for 0ccd92f

• Evaluate in numerical order

  vrza

  committed
  712b536

  Copy full SHA for 712b536

• Guard Linux-specific P_PIDFD constant

  vrza

  committed
  dfe3bfe

  Copy full SHA for dfe3bfe

• Linux-specific iptype validation

  vrza

  committed
  e23bc2d

  Copy full SHA for e23bc2d

• Include linux/wait.h on Linux to check for idtype constants

  vrza

  committed
  651df1f

  Copy full SHA for 651df1f

• Leave idtype and flags validation out as it is platform-specific

  vrza

  committed
  3ab725d

  Copy full SHA for 3ab725d

• Added FreeBSD specific idtypes

  vrza

  committed
  93f4fad

  Copy full SHA for 93f4fad

• Added NetBSD specific idtypes

  vrza

  committed
  ee6b65d

  Copy full SHA for ee6b65d

• Added check for linux/wait.h

  vrza

  committed
  4830687

  Copy full SHA for 4830687

• Guard pcntl_waitid behind HAVE_WAITID

  vrza

  committed
  e3cfd08

  Copy full SHA for e3cfd08

• Test pcntl_waitid failing due to invalid arguments

  vrza

  committed
  ba5d347

  Copy full SHA for ba5d347

• Pick a better bad value for idtype in test

  vrza

  committed
  324b79c

  Copy full SHA for 324b79c

• Removed unnecessary comments

  vrza

  committed
  ab07bc0

  Copy full SHA for ab07bc0

• Comment on NetBSD specific idtypes

  vrza

  committed
  f01aeb3

  Copy full SHA for f01aeb3

Commits on Jun 21, 2024

• Renamed variable success to status

  vrza

  committed
  52fce3d

  Copy full SHA for 52fce3d

• Made the id param to waitid nullable

  vrza

  committed
  d39033a

  Copy full SHA for d39033a

• Expect warnings about invalid arguments

  vrza

  committed
  5deaba1

  Copy full SHA for 5deaba1

• More tests, including testing error messages

  vrza

  committed
  e1399cf

  Copy full SHA for e1399cf

• Implemented weak idtype validation

  vrza

  committed
  d173be1

  Copy full SHA for d173be1

• Added test for weak idtype validation

  vrza

  committed
  5793dcd

  Copy full SHA for 5793dcd

• Added tests with PHP_INT_MAX

  vrza

  committed
  509c92f

  Copy full SHA for 509c92f

• Throw ValueError on errno == EINVAL

  vrza

  committed
  31f3856

  Copy full SHA for 31f3856

Commits on Jun 22, 2024

• Added test for null id when idtype != P_ALL

  vrza

  committed
  a0df466

  Copy full SHA for a0df466

Commits on Jun 23, 2024

• Moved idtype constants detection to autoconf

  Show description for 8763548
  vrza

  committed
  8763548

  Copy full SHA for 8763548

• Fixed typo in comment

  vrza

  committed
  5021e88

  Copy full SHA for 5021e88

• FreeBSD fixes

  vrza

  committed
  1bf8873

  Copy full SHA for 1bf8873

• macOS fills in siginfo_t even on no state change

  vrza

  committed
  25fc4db

  Copy full SHA for 25fc4db

• Changed API to closely match wait and waitpid

  vrza

  committed
  2df267a

  Copy full SHA for 2df267a

• AC_CHECK_DECLS for WEXITED, WSTOPPED, WNOWAIT

  vrza

  committed
  9124b1e

  Copy full SHA for 9124b1e

Commits on Jun 24, 2024

• Test pcntl_get_last_error()

  vrza

  committed
  80a1da8

  Copy full SHA for 80a1da8

• AC_CHECK_DECLS superseded importing linux/wait.h

  vrza

  committed
  ea33122

  Copy full SHA for ea33122

• Improved m4 code intentation

  vrza

  committed
  5f540d8

  Copy full SHA for 5f540d8

Commits on Jun 25, 2024

• Better default params

  vrza

  committed
  595b9c4

  Copy full SHA for 595b9c4

• Fixed bad value for zend long

  vrza

  committed
  0011541

  Copy full SHA for 0011541

• Stricter preprocessor guards

  vrza

  committed
  1993ec1

  Copy full SHA for 1993ec1

Commits on Jun 26, 2024

• Updated NEWS

  vrza

  committed
  19e0612

  Copy full SHA for 19e0612

Commits on Jun 27, 2024

• Fixed race condition in unit tests

  vrza

  committed
  207ea17

  Copy full SHA for 207ea17

• Marked unused param with underscore

  vrza

  committed
  e69f6c7

  Copy full SHA for e69f6c7

• m4 formatting

  vrza

  committed
  ed38397

  Copy full SHA for ed38397