Skip to content

fixes #13773: DatePeriod does not take microseconds into account #14581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

marc-mabe
Copy link
Contributor

This should fix #13773

@marc-mabe marc-mabe force-pushed the DatePeriod-microseconds branch from b4bff1a to e8c658e Compare June 16, 2024 07:57
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-mabe
Copy link
Contributor Author

Can this one be merged for PHP 8.4 or do I still need to do something here?

derickr added a commit that referenced this pull request Aug 21, 2024
@derickr
Copy link
Member

derickr commented Aug 21, 2024

Merged after a rebase and adding the NEWS entry.

@derickr derickr closed this Aug 21, 2024
@marc-mabe marc-mabe deleted the DatePeriod-microseconds branch August 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePeriod not taking into account microseconds for end date
2 participants