Refactor SHADOW_STACK_SYSCALL check #14575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes -Wundef warnings present where SHADOW_STACK_SYSCALL should be defined to value 0 and refactors the check with cache variable php_cv_have_shadow_stack_syscall. The SHADOW_STACK_SYSCALL CPP macro definition is removed from php_config.h in favor of a compilation definition on asm files and Zend engine files.
arnaud-lb
approved these changes
Jun 15, 2024
|
Ok, thanks for the review. I've merged this one and then only that configure.ac part needs to be rebased a bit in the above PR. If further adjustments are needed let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes -Wundef warnings present where SHADOW_STACK_SYSCALL should be defined to value 0 and refactors the check with cache variable php_cv_have_shadow_stack_syscall. The SHADOW_STACK_SYSCALL CPP macro definition is removed from php_config.h in favor of a compilation definition on asm files and Zend engine files.