Skip to content

Disable LSAN for crashing SOAP tests #14562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iluuu1994
Copy link
Member

No description provided.

@nielsdos
Copy link
Member

FWIW, these spurious crashes already happened prior to me doing those recent bugfixes, so they're not regressions.
That said, the addresses on which it crashes on seem like bogus addresses to me on first sight, so I wonder if this is an uninitialized memory problem.
Or, it's a stability issue with CI + LSAN, similarly to ones we saw earlier (which caused us to upgrade to LLVM 16).
I also don't know if this patch would properly prevent these crashes: there's still some LSAN logic running even without leak detection enabled...

@iluuu1994
Copy link
Member Author

Yeah, it's just a quickfix. We can packport the upgrading of LLVM if you prefer, but this also seems to be enough to do the trick, at least to make the build green.

@nielsdos
Copy link
Member

I'm fine with this.

but this also seems to be enough to do the trick, at least to make the build green.

How do you know that? It seems to fail at random moments.

@iluuu1994
Copy link
Member Author

iluuu1994 commented Jun 13, 2024

@nielsdos I don't think so. The 8.3 branch fails consistently, but not 8.2 or master.

@nielsdos
Copy link
Member

Huh, okay, fine by me then

@iluuu1994
Copy link
Member Author

Anyway, you're right that backporting the LLVM update is better. So let me create a new PR for that to see if it works for this branch too.

@iluuu1994
Copy link
Member Author

Seems it (#14569) solves the problem for the PHP 8.3 branch as well, so let's go with that.

@iluuu1994 iluuu1994 closed this Jun 14, 2024
@iluuu1994 iluuu1994 reopened this Aug 14, 2024
@iluuu1994 iluuu1994 force-pushed the disable-lsan-for-crashing-soap-tests branch from 3bfc964 to 65a101f Compare August 14, 2024 09:44
iluuu1994 added a commit that referenced this pull request Aug 14, 2024
* PHP-8.3:
  Disable LSAN for crashing SOAP tests (GH-14562)
@iluuu1994 iluuu1994 merged commit 65a101f into php:PHP-8.3 Aug 14, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants