Skip to content

Update ext/spl as required dependency for ext/pdo #14535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

Update ext/spl as required dependency for ext/pdo #14535

merged 1 commit into from
Jun 11, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 10, 2024

Since ZEND_MOD_REQUIRED is used and spl can't be disabled, this marks the configure time dependency also as required.

@petk
Update ext/spl as required dependency for ext/pdo
f36cd92 
Since ZEND_MOD_REQUIRED is used and spl can't be disabled, this marks
the configure time dependency also as required.
@petk petk requested a review from SakiTakamachi as a code owner June 10, 2024 21:03
Girgias
Girgias approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get round to the RFC to stop have extension exceptions be based on the SPL one. As those should not interact.

@petk petk merged commit bd7b174 into php:master Jun 11, 2024
11 checks passed
@petk petk deleted the patch-pdo-dependencies branch June 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @Girgias