Skip to content

ext/gd using fast ZPP. #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

ext/gd using fast ZPP. #14534

merged 1 commit into from
Jun 11, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen marked this pull request as ready for review June 10, 2024 21:52
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue but looks good to me otherwise

@devnexen devnexen merged commit 1ae5443 into php:master Jun 11, 2024
11 checks passed
@thg2k
Copy link
Contributor

thg2k commented Jun 11, 2024

Is there a reaon why we are doing this? I thought the idea was to use the fast ZPP only on critical functions that are invoked a lot due to the lesser readability of the code.

In this case, i can only think of a few functions where this might make sense, imagecolor[allocate|resolve] and images[x|y], for the rest, any speed gain is negligible compared to the rest of the processing time.

Or is this going to happen on the full php codebase?

@devnexen
Copy link
Member Author

It is still a gain :)
It is more convenient also when there is a certain amount of arguments, it is easier to follow I find.
I m not sure it will happen to the full codebase though but can t speak for it.

@Girgias
Copy link
Member

Girgias commented Jun 11, 2024

The main reason against it was because of code size as the "old" zpp is a function call, but the actual impact of it is not that big so it seems fine to "just" convert them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants