Skip to content

Leverage object_init_with_constructor() in zend_get_attribute_object() #14532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2024
Merged

Leverage object_init_with_constructor() in zend_get_attribute_object() #14532

merged 1 commit into from
Jun 10, 2024

Conversation

TimWolla
Copy link
Member

No description provided.

@TimWolla TimWolla requested a review from Girgias June 10, 2024 08:37
TimWolla
TimWolla commented Jun 10, 2024
View reviewed changes
Zend/tests/attributes/005_objects.phpt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is due to:

php-src/Zend/zend_API.c

Lines 1872 to 1874 in bca0c08

/* Surprisingly, this is the only case where internal classes will allow to pass extra arguments
* However, if there are named arguments (and it is not empty),
* an Error must be thrown to be consistent with new ClassName() */

Girgias
Girgias approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@TimWolla TimWolla merged commit 193d385 into php:master Jun 10, 2024
11 checks passed
@TimWolla TimWolla deleted the zend-get-attribute-object-init-with-constructor branch June 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Category: Engine Extension: reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @Girgias