Skip to content

Sync #if/ifdef/defined #14520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Sync #if/ifdef/defined #14520

merged 1 commit into from
Jun 11, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 9, 2024

These are either undefined or defined (to value 1):

  • __DragonFly__
  • __FreeBSD__
  • HAS_MCAST_EXT
  • HAVE_GETCWD
  • HAVE_GETWD
  • HAVE_GLIBC_ICONV
  • HAVE_JIT
  • HAVE_LCHOWN
  • HAVE_NL_LANGINFO
  • HAVE_RL_CALLBACK_READ_CHAR
  • HAVE_RL_ON_NEW_LINE
  • HAVE_SQL_EXTENDED_FETCH
  • HAVE_UTIME

Follow up of GH-5526 (-Wundef)

These are either undefined or defined (to value 1):
- __DragonFly__
- __FreeBSD__
- HAS_MCAST_EXT
- HAVE_GETCWD
- HAVE_GETWD
- HAVE_GLIBC_ICONV
- HAVE_JIT
- HAVE_LCHOWN
- HAVE_NL_LANGINFO
- HAVE_RL_CALLBACK_READ_CHAR
- HAVE_RL_ON_NEW_LINE
- HAVE_SQL_EXTENDED_FETCH
- HAVE_UTIME

Follow up of phpGH-5526 (-Wundef)
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack for ext/random

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for sockets

@petk
Copy link
Member Author

petk commented Jun 11, 2024

Merge coming up here. These aren't problematic changes overall.

@petk petk merged commit 5d3fab9 into php:master Jun 11, 2024
11 checks passed
@petk petk deleted the patch-wundef-3 branch June 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants