Fix typo s/PGVERSION_NUM/PG_VERSION_NUM #14516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
approved these changes
Jun 9, 2024
|
Or maybe I've merged this too quickly. Typo is certain, yes. But something isn't ok here yet, I think. I'll recheck, if I find some solution. Because this |
|
See here. |
|
PR here: #14519 Issue is that pg_config.h is not included which has this PG_VERSION_NUM. And this header doesn't seem to be meant to be included when only libpq is installed. At least from what I see (PostgreSQL 16). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken, this one is in <pg_config.h> but I'm not sure if it is included anywhere or intended to be used by the PostgreSQL API.