Skip to content

Fix GH-13681: segfault when adding watchpoint fails. #14513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jun 8, 2024

thus when removing its entry, no watch point is set and crash on pointer access.

@devnexen devnexen force-pushed the gh-13681 branch 2 times, most recently from de2611e to 760d3d0 Compare June 8, 2024 22:36
@devnexen devnexen marked this pull request as ready for review June 9, 2024 05:28
devnexen added 2 commits June 9, 2024 07:08
thus when removing its entry, no watch point is set and crash on
pointer access.
@devnexen devnexen requested review from nielsdos, bwoebi and Girgias and removed request for nielsdos June 10, 2024 11:35
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about PHPDBG, but this change looks correct to prevent the NULL pointer dereferencement.

@devnexen devnexen closed this in 03f0776 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants