Phar offset exist issue with entry classes not based on PharFileInfo #14503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
phar-offset-exist-issue
branch
from
ca3e379 to
f434a44
Compare
Girgias
force-pushed
the
phar-offset-exist-issue
branch
from
f434a44 to
69451e4
Compare
nielsdos
approved these changes
Aug 23, 2024
|
I have no idea what the rationale is, and when I talked to people that use/build phar they didn't even know you could have something other than PharFileInfo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for the existence of a directory the entry CE should be based on PharFileInfo, as SplFileInfo does not accept directories.