Fix parameter numbers and missing alpha check for imagecolorset() #14477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for the alpha parameter existed in PHP 7.4 but was lost in PHP 8.0. Fixes: 5076507
nielsdos
approved these changes
Jun 5, 2024
nielsdos
pushed a commit
that referenced
this pull request
Jun 5, 2024
This is the 8.2 & 8.3 version of GH-14477.
|
Wonderful, that's exactly how I would've done it, including the test with the NULL 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
I'm targeting master due to the additional check in the alpha parameter, as it is not a bug strictly speaking, I wouldn't like to break code that relies on this loose behavior on a patch release.
I'm available to retarget a lower branch or even split this into two PRs: one for fixing the parameter indexes (that is a bug), and one for adding the missing check (targeting master), just let me know.