Remove WINDOWS symbol from ext/ldap/ldap.c #14468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WINDOWS symbol was used up to commit f79688e where it got undefined when condition `#if WIN32|WINNT` was met. Then the condition was replaced with simpler PHP_WIN32 (which today implies also 64-bit platforms) and WINDOWS is undefined in this file when targeting Windows platform. Conditions otherwise also work on Windows anyway because of the LDAP_API_VERSION check.
Girgias
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WINDOWS symbol was used up to commit
f79688e where it got undefined when condition
#if WIN32|WINNTwas met. Then the condition was replaced with simpler PHP_WIN32 (which today implies also 64-bit platforms) and WINDOWS is undefined in this file when targeting Windows platform. Conditions otherwise also work on Windows anyway because of the LDAP_API_VERSION check.