Skip to content

Replace WINDOWS with PHP_WIN32 in ext/standard/filestat.c #14464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 4, 2024

The WINDOWS symbol is project defined symbol in most cases and can be replaced with PHP_WIN32 in this case at this point.

The WINDOWS symbol is project defined symbol in most cases and can be
replaced with PHP_WIN32 in this case at this point.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lctm

@petk petk merged commit 58f3b67 into php:master Jun 7, 2024
11 checks passed
@petk petk deleted the patch-ext-standard-filestat-c branch June 7, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants