Skip to content

Fixed GH-14383: Fixed usec was carry up #14463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Jun 4, 2024

If round the fractional part of a timestamp to 6 digits, a carry will occur in cases such as .999_999_9 to .100_000. In that case, set usec to 0 and add 1 to sec.

fixes #14383

Since this is an unreleased feature, I don't think it is necessary to update the NEWS entry. How do you think?

If round to the fractional part of a timestamp, a carry will occur in cases
such as 999 999 9. In that case, set usec to 0 and add 1 to sec.
@SakiTakamachi SakiTakamachi changed the title Fixed a problem where usec was carry up Fixed GH-14383: Fixed a problem where usec was carry up Jun 6, 2024
@SakiTakamachi SakiTakamachi changed the title Fixed GH-14383: Fixed a problem where usec was carry up Fixed GH-14383: Fixed usec was carry up Jun 6, 2024
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SakiTakamachi SakiTakamachi merged commit bfc9885 into php:master Jun 11, 2024
11 checks passed
@SakiTakamachi SakiTakamachi deleted the fix/gh-14383 branch June 11, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DateTime::createFromTimestamp overflowed microseconds value
3 participants