Fix bug #69280: SoapClient classmap doesn't support fully qualified class name #14398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jun 1, 2024
…lass name There's a hash table that maps type names to class name, but names with a leading backslash are not supported. The engine has logic to strip away the leading backslash that we should replicate here. It works by checking if we need to make an actual copy in case an unexpected (e.g. invalid data or leading backslash) situations are detected. Upon making a copy we normalize the data in the table. Furthermore, previously the code assumed that the key was always valid and that the structure was a non-packed hash table. This isn't necessarily the case. The new code fixes this as well. Closes phpGH-14398.
nielsdos
added a commit
that referenced
this pull request
Jun 1, 2024
* PHP-8.2: Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)
nielsdos
added a commit
that referenced
this pull request
Jun 1, 2024
* PHP-8.3: Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)
nielsdos
added a commit
that referenced
this pull request
Aug 7, 2024
* PHP-8.2: Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"
nielsdos
added a commit
that referenced
this pull request
Aug 7, 2024
* PHP-8.3: Revert "Fix bug #69280: SoapClient classmap doesn't support fully qualified class name (#14398)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a hash table that maps type names to class name, but names with
a leading backslash are not supported. The engine has logic to strip
away the leading backslash that we should replicate here.
It works by checking if we need to make an actual copy in case an
unexpected (e.g. invalid data or leading backslash) situations are
detected. Upon making a copy we normalize the data in the table.
Furthermore, previously the code assumed that the key was always valid
and that the structure was a non-packed hash table. This isn't
necessarily the case. The new code fixes this as well.