Sync #if/ifdef/defined #14371
Merged
Sync #if/ifdef/defined #14371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are either undefined or defined to value 1 in Autotools and Windows: - HAVE_COMMONCRYPTO_COMMONRANDOM_H - HAVE_EXIF - HAVE_FOPENCOOKIE - HAVE_IF_NAMETOINDEX - HAVE_LIBICONV - HAVE_SOCKETS - HAVE_STRUCT_STAT_ST_RDEV - HAVE_STRUCT_TM_TM_GMTOFF - HAVE_STRUCT_TM_TM_ZONE Follow up of phpGH-5526 (-Wundef)
petk
requested review from
bukka,
devnexen,
TimWolla,
zeriyoshi and
derickr
as code owners
zeriyoshi
approved these changes
May 30, 2024
bukka
approved these changes
May 31, 2024
|
I think all is good here. I'll merge this one in the following days. cc @derickr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are either undefined or defined to value 1 in Autotools and Windows:
Follow up of GH-5526 (-Wundef)