ext/intl: Various refactoring #14360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always throw a Error exception as we cannot progress from here
devnexen
reviewed
May 29, 2024
devnexen
reviewed
May 29, 2024
| err_msg = intl_error_get_message(BREAKITER_ERROR_P(bio_orig)); | ||
| zend_throw_exception(NULL, ZSTR_VAL(err_msg), 0); | ||
| zend_string_free(err_msg); | ||
| zend_throw_error(NULL, "Failed to clone BreakIterator"); |
There was a problem hiding this comment.
these are the best parts of the refactoring :)
Drive-by refactoring
Probably more cleanup can be done
Girgias
force-pushed
the
intl-error-docref
branch
from
003088a to
665c7fc
Compare
devnexen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best to review this PR commit by commit.