Refactor fopencookie check #14346
Merged
Refactor fopencookie check #14346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
May 28, 2024
petk
commented
- This checks for a type cookie_io_functions_t and defines the HAVE_FOPENCOOKIE based on type check result and the fopencookie() function presence.
- Fixed -Wunused... warnings in config.log on stricter compiler configurations
- The run check for off64_t is wrapped into AC_CACHE_CHECK for having the php_cv_type_cookie_off64_t cache variable available to customize possible cross-compilation edge cases
- Comment about glibcs 2.1.2 removed because also some other earlier versions provided this type already
- This checks for a type cookie_io_functions_t and defines the HAVE_FOPENCOOKIE based on type check result and the fopencookie() function presence. - Fixed -Wunused... warnings in config.log on stricter compiler configurations - The run check for off64_t is wrapped into AC_CACHE_CHECK for having the php_cv_type_cookie_off64_t cache variable available to customize possible cross-compilation edge cases - Comment about glibcs 2.1.2 removed because also some other earlier versions provided this type already
|
I'll recheck this if this even needs a run check in the first place or if maybe it can be done with AC_CHECK_COMPILE... |
|
Let's leave this run check then here for now. It can be probably simplified in the future to only check for off64_t type but it's not so certain in case some C library will have the off64_t but this seeker might be using different definition. |
arnaud-lb
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.