Fix gen_stub.php errors #14335
Merged
Fix gen_stub.php errors #14335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the fixes! |
|
I looked at this error a while ago, and it happens when running the script with an old version of PHP (<8.0): So, I think if this error is fixed, we should probably do so for lower branches (as the chance of running the script with an older version seems higher there). |
|
OK, I'll port them to the lower branches! |
kocsismate
pushed a commit
that referenced
this pull request
May 27, 2024
kocsismate
added a commit
that referenced
this pull request
May 27, 2024
* PHP-8.2: Fix gen_stub.php errors (#14335)
kocsismate
added a commit
that referenced
this pull request
May 27, 2024
* PHP-8.3: Fix gen_stub.php errors (#14335)
|
Done |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
gen_stub.phpthrows from time to time (see https://app.travis-ci.com/github/php/php-src/builds/270649670#L2166). Here's the fix.